NVIDIA-Merlin / Merlin

NVIDIA Merlin is an open source library providing end-to-end GPU-accelerated recommender systems, from feature engineering and preprocessing to training deep learning models and running inference in production.
Apache License 2.0
758 stars 113 forks source link

[RMP]Merlin Unit tests #428

Open viswa-nvidia opened 2 years ago

viswa-nvidia commented 2 years ago

Problem:

The current set of unit tests doesn't cover all examples. Additional examples must be added. We need multiple repo unit tests to run on any given repo commit. This will ensure that the changes in the repo submitted work against the current version of any merlin packages that may depend on it.

Goal:

The goal of this work is to be able to run merlin unit tests from all affected (down stream) repos.

Constraints:

Starting Point:

Most of these can be handled with #408

viswa-nvidia commented 2 years ago

@jperez999 , this was discussed in the last weekly sync. Could you please point me to the tickets and also update the rest of the sections below

EvenOldridge commented 2 years ago

@viswa-nvidia I believe this is already tracked here: https://github.com/NVIDIA-Merlin/Merlin/issues/343

viswa-nvidia commented 2 years ago

@EvenOldridge , https://github.com/NVIDIA-Merlin/Merlin/issues/343 tracks integration tests. This is to track unit tests. Let me know if you still see duplication.