NVIDIA-Merlin / NVTabular

NVTabular is a feature engineering and preprocessing library for tabular data designed to quickly and easily manipulate terabyte scale datasets used to train deep learning based recommender systems.
Apache License 2.0
1.05k stars 143 forks source link

Add fixture to cleanup dataloader after each test runs #1852

Closed oliverholworthy closed 1 year ago

oliverholworthy commented 1 year ago

Follow-up to #1848

Adds a fixture to cleanup dataloader after each test runs. This ensures that if a test using the Merlin Dataloader only partially consumes a dataloader instance (and isn't using it as a context manager (with statement), or calling stop explicitly). Then we automatically clean it up by calling stop on it (it's ok if we call stop more than once).

github-actions[bot] commented 1 year ago

Documentation preview

https://nvidia-merlin.github.io/NVTabular/review/pr-1852