NVIDIA-Merlin / Transformers4Rec

Transformers4Rec is a flexible and efficient library for sequential and session-based recommendation and works with PyTorch.
https://nvidia-merlin.github.io/Transformers4Rec/main
Apache License 2.0
1.11k stars 146 forks source link

[DRAFT] Remove the custom padding in T4Rec's MerlinDataLoader #696

Closed sararb closed 1 year ago

sararb commented 1 year ago

Goals :soccer:

The Merlin data loader has a Padding operator that we can pass via the transforms parameter. To avoid code redundancy, I created a PR in T4Rec that removes custom padding from the T4Rec's MerlinDataLoader class. In this PR, the default behavior of the Trainer is to set the data loader without padding. If the user wants to perform padding outside of the model, they can explicitly provide a data loader with a Padding transform.

Implementation Details :construction:

Testing Details :mag:

sararb commented 1 year ago

Closing this as a solution in favor of updating the T4Rec padding code is implemented in #690