implement review suggestions

NVIDIA-Merlin / models

Merlin Models is a collection of deep learning recommender system model reference implementations

https://nvidia-merlin.github.io/models/main/index.html

Apache License 2.0

262 stars 50 forks source link

implement review suggestions #1062

Closed radekosmulski closed 1 year ago

radekosmulski commented 1 year ago

We merged #1045 to meet the cutoff, but there were some outstanding review comments from @rnyak and @edknv. This PR implements the suggestions mentioned on #1045

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 1 year ago

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1062

radekosmulski commented 1 year ago

rerun tests

radekosmulski commented 1 year ago

rerun tests

oliverholworthy commented 1 year ago

rerun tests

adding comments to the PR to trigger re-runs of tests I don't think is required/works anymore. This was previously to re-trigger a test run of the GPU-based tests that were running in Jenkins. Now that we have a self-hosted GitHub Actions runner for that, the way to trigger a re-run is to open the Details page of the relevant failed check and use the Re-run jobs button at the top right of the page.

radekosmulski commented 1 year ago

Thank you for the heads up, @oliverholworthy! 🙂