NVIDIA-Merlin / models

Merlin Models is a collection of deep learning recommender system model reference implementations
https://nvidia-merlin.github.io/models/main/index.html
Apache License 2.0
262 stars 50 forks source link

We need to remove README after the hyper link. #1163

Closed tien-nguyen closed 1 year ago

tien-nguyen commented 1 year ago

Fixes # (issue)

Goals :soccer:

Remove the README in the hyperlink as if we have it there, it is not correct.

Implementation Details :construction:

I remove the README in the hyperlink.

Testing Details :mag:

I tested on the web URL: https://nvidia-merlin.github.io/models/stable/examples/ , this is the correct link.

rapids-bot[bot] commented 1 year ago

Pull requests from external contributors require approval from a NVIDIA-Merlin organization member with write permissions or greater before CI can begin.

github-actions[bot] commented 1 year ago

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1163

tien-nguyen commented 1 year ago

@oliverholworthy @marcromeyn thank you for approving this pull request. I needed to add a label for this (maybe label=documentation). I cannot add labels as I cannot find any. I may need to convert this to a draft first, and add the label (please see the attachment).

Is that a right approach to do so?

Thank you.

Screenshot 2023-06-30 at 7 48 44 AM

oliverholworthy commented 1 year ago

@tien-nguyen thanks for opening this PR to fix the link, labels can only be added by maintainers currently. I applied the documentation label and merged the change.

tien-nguyen commented 1 year ago

Thank you.