NVIDIA-Merlin / models

Merlin Models is a collection of deep learning recommender system model reference implementations
https://nvidia-merlin.github.io/models/main/index.html
Apache License 2.0
262 stars 50 forks source link

Change model call default arg values to None instead of bool vals #1218

Closed oliverholworthy closed 11 months ago

oliverholworthy commented 11 months ago

This fixes an issue with model saving where the concrete function cannot be matched correctly

Fixes #1217

Goals :soccer:

Enable transformer-based retrieval models can be saved an reloaded multiple times across different processes

Implementation Details :construction:

When saving and reloading and then saving a model again in a different python process, we encounder some issues with the optional arguments to the call method of the model.

Chaning these to None instead of the boolean default value of False seems to avoid the error.

Testing Details :mag:

Tested reload and save of model from gist in #1217

github-actions[bot] commented 11 months ago

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1218