search

NVIDIA-Merlin / models

Merlin Models is a collection of deep learning recommender system model reference implementations
https://nvidia-merlin.github.io/models/main/index.html
Apache License 2.0
262 stars 50 forks source link

Fix sok import error in ut #1231

Closed EmmaQiaoCh closed 9 months ago

EmmaQiaoCh commented 9 months ago

SOK has refactored the code path and remove experiment. There are ut failure in tests/unit/tf/horovod/test_embedding.py due to below error: ImportError: 'horovod' and 'sparse_operation_kit' are required to use SOKEmbedding.

copy-pr-bot[bot] commented 9 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

EmmaQiaoCh commented 9 months ago

/ok to test

edknv commented 9 months ago

Duplicate: https://github.com/NVIDIA-Merlin/models/pull/1232.