Checkpoint refactoring - recognize checkpoints by operator instance name.

mzient commented 3 weeks ago

Category:

Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

Use operator names rather than incidental order in checkpoints. Get operator instances from executor (by name) rather than from lowered graph (by index). Rationale:

new graph doesn't store operator instances - that's the job of the executor
order of operators in the graph is incidental and brittle

Additionally, OpCheckpoint is now only forward-declared in operator.h, because most operators are stateless and don't need to depend on OpCheckpoint definition.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

Tests adjusted (not added)

[ ] Existing tests apply
[ ] New tests added
- [ ] Python tests
- [X] GTests
- [ ] Benchmark
- [ ] Other
[ ] N/A

Checklist

Documentation

[ ] Existing documentation applies
[ ] Documentation updated
- [ ] Docstring
- [ ] Doxygen
- [ ] RST
- [ ] Jupyter
- [ ] Other
[X] N/A

DALI team only

Requirements

[ ] Implements new requirements
[ ] Affects existing requirements
[X] N/A

REQ IDs: N/A

JIRA TASK: DALI-3979