Add failure tests for stealing subgraphs. Minor fix in pipeline. - Githubissues

NVIDIA / DALI

A GPU-accelerated library containing highly optimized building blocks and an execution engine for data processing to accelerate deep learning training and inference applications.

https://docs.nvidia.com/deeplearning/dali/user-guide/docs/index.html

Apache License 2.0

4.98k stars 609 forks source link

Add failure tests for stealing subgraphs. Minor fix in pipeline. #5518

Closed mzient closed 3 weeks ago

mzient commented 3 weeks ago

Follow-up on #5506

Category:

Bug fix (non-breaking change which fixes an issue) Other (e.g. Documentation, Tests, Configuration)

Description:

This change adds failure tests to the pipeline, detecting:

uncheckpointable pipeline (with foreign subgraph)
invalid pipeline (with duplicate node names)

Minor fix:

error out in Python (instead of C++) when adding a node with a duplicate name

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

[ ] Existing tests apply
[X] New tests added
- [ ] Python tests
- [X] GTests
- [ ] Benchmark
- [ ] Other
[ ] N/A

Checklist

Documentation

[ ] Existing documentation applies
[ ] Documentation updated
- [ ] Docstring
- [ ] Doxygen
- [ ] RST
- [ ] Jupyter
- [ ] Other
[X] N/A

DALI team only

Requirements

[ ] Implements new requirements
[ ] Affects existing requirements
[X] N/A

REQ IDs: N/A

JIRA TASK: N/A

dali-automaton commented 3 weeks ago

CI MESSAGE: [15740515]: BUILD STARTED

dali-automaton commented 3 weeks ago

CI MESSAGE: [15740515]: BUILD PASSED