search

NVIDIA / Fuser

A Fusion Code Generator for NVIDIA GPUs (commonly known as "nvFuser")
Other
271 stars 53 forks source link

patch potential segfault #3262

Closed jjsjann123 closed 3 weeks ago

jjsjann123 commented 4 weeks ago

Not sure how this could happen.

jjsjann123 commented 4 weeks ago

!build

jjsjann123 commented 4 weeks ago

!build

jjsjann123 commented 4 weeks ago

!build

jjsjann123 commented 4 weeks ago

Saw this in the CI that could be relevant.

00:21:30 [ RUN      ] ResizeTest.CatMemoryPromotionReducedFloating
00:21:30 To reproduce: NVFUSER_TEST_RANDOM_SEED=1729857248 NVFUSER_TEST_ATEN_RANDOM_SEED=0 nvfuser_tests --gtest_filter='ResizeTest.CatMemoryPromotionReducedFloating'
00:21:30 unknown file: Failure
00:21:30 C++ exception with description " INTERNAL ASSERT FAILED at "/opt/pytorch/nvfuser/tests/cpp/validator.cpp":111, please report a bug with repro script to NVFuser at https://github.com/NVIDIA/Fuser/issues. 
00:21:30 
00:21:30 Validation error in output 0 on line 3541 in file /opt/pytorch/nvfuser/tests/cpp/test_resize.cpp.
00:21:30   Detected max abs error of: 6.05469
00:21:30     absolute tolerance was set to 0.00390625
00:21:30     and relative tolerance set to 0.0078125

Oops, indeed caused by the changes in this PR. Working on it now.

jjsjann123 commented 4 weeks ago

!build

jjsjann123 commented 4 weeks ago

!build

jjsjann123 commented 4 weeks ago

tagging @naoyam for the added test.

jjsjann123 commented 3 weeks ago

!build

jjsjann123 commented 3 weeks ago

!build

jjsjann123 commented 3 weeks ago

CI looks promising.