search

NVIDIA / Fuser

A Fusion Code Generator for NVIDIA GPUs (commonly known as "nvFuser")
Other
271 stars 53 forks source link

Prevent marking inplace update target as candidate for alias analysis #3401

Closed jjsjann123 closed 6 days ago

jjsjann123 commented 1 week ago

We shouldn't inplace-update target as candidate for alias analysis.

Since the update requires a real kernel, marking it as candidate for alias could lead to unnecessary segmentation that cannot be handled by trivially evaluating with meta operations on an existing Tensor.

jjsjann123 commented 1 week ago

!test

jjsjann123 commented 1 week ago

The issue was found from here: https://github.com/Lightning-AI/lightning-thunder/issues/1173

jjsjann123 commented 1 week ago

!test

wujingyue commented 1 week ago

Nit: can you write a better title for the PR than "fixing alias analysis stuff"?

jjsjann123 commented 1 week ago

!test