search

NVIDIA / JAX-Toolbox

JAX-Toolbox
Apache License 2.0
210 stars 35 forks source link

Fix Triton build again #899

Closed olupton closed 1 month ago

olupton commented 1 month ago

AMD headers are included unconditionally; the simplest approach is to make sure they exist.

DwarKapex commented 1 month ago

LGTM. Did you file a bug to upstream?

olupton commented 1 month ago

Did you file a bug to upstream?

No, I don't think there's anyone that would want to fix this for us, so I'm not sure who I could file a bug with.

The problem is that (openxla/triton, bazel) typically works, and is used in XLA, and (openai/triton, cmake+wheel) typically works, but here we are trying to build (openxla/triton, cmake+wheel), and this sometimes breaks.