NVIDIA / MinkowskiEngine

Minkowski Engine is an auto-diff neural network library for high-dimensional sparse tensors
https://nvidia.github.io/MinkowskiEngine
Other
2.43k stars 360 forks source link

Invalid automatic min_coordinate calculation for SparseTensor.dense #570

Open matthewdm0816 opened 9 months ago

matthewdm0816 commented 9 months ago

Document on SparseTensor indicates that, min_coordinate will be automatically computed if 0 is given. But it seems that the first assertion will throw error for any non-torch tensor inputs. There are correct codes below but will never be used under the first assert.

https://github.com/NVIDIA/MinkowskiEngine/blob/02fc608bea4c0549b0a7b00ca1bf15dee4a0b228/MinkowskiEngine/MinkowskiSparseTensor.py#L488-L526