NVIDIA / NVFlare

NVIDIA Federated Learning Application Runtime Environment
https://nvidia.github.io/NVFlare/
Apache License 2.0
592 stars 165 forks source link

Fix DockerBuilder to add `build` section #2662

Closed apatole closed 2 months ago

apatole commented 2 months ago

Fixes # .

The compose.yml generated by the DockerBuilder class adds a build section only for the overseer. As a result, when we have non-HA mode project.yml, generated compose.yml won't have the build section and so docker compose build won't build the required NVFlare docker image.

This change adds a build section in the generated compose.yml even for clients and servers. It fixes the above issue and also with this change, same compose.yml can be used to build/run individual servers and clients using the docker compose method.

Types of changes

apatole commented 2 months ago

Hi @chesterxgchen , uploaded a small fix for the DockerBuilder. I was using DockerBuilder last week and was wondering why docker compose build is not building the required nvflare-service image. I then later realized that the generated compose.yml was missing the build sections. thanks.

chesterxgchen commented 2 months ago

@IsaacYangSLA can help with this

IsaacYangSLA commented 2 months ago

/build