Closed apatole closed 2 months ago
Hi @chesterxgchen , uploaded a small fix for the DockerBuilder. I was using DockerBuilder last week and was wondering why docker compose build
is not building the required nvflare-service
image. I then later realized that the generated compose.yml
was missing the build
sections. thanks.
@IsaacYangSLA can help with this
/build
Fixes # .
The
compose.yml
generated by theDockerBuilder
class adds a build section only for the overseer. As a result, when we have non-HA modeproject.yml
, generatedcompose.yml
won't have the build section and sodocker compose build
won't build the required NVFlare docker image.This change adds a build section in the generated
compose.yml
even for clients and servers. It fixes the above issue and also with this change, samecompose.yml
can be used to build/run individual servers and clients using thedocker compose
method.Types of changes