Change the ScatterAndGather default persistor_id

NVIDIA / NVFlare

NVIDIA Federated Learning Application Runtime Environment

https://nvidia.github.io/NVFlare/

Apache License 2.0

592 stars 165 forks source link

Closed yhwen closed 1 month ago

yhwen commented 1 month ago

Fixes # .

Changed the ScatterAndGather default persistor_id value from "" to "persistor".

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[ ] New tests added to cover the changes.
[ ] Quick tests passed locally by running ./runtest.sh.
[ ] In-line docstrings updated.
[ ] Documentation updated.

yhwen commented 1 month ago

Not sure this is a safe change. See my comments.

changed the docstring of persistor_id in ScatterAndGather to default to empty string. Made this to match the "persistor_id" parameter definition.