Added id to the jobAPI swarm_script_executor_cifar10 component deploy

NVIDIA / NVFlare

NVIDIA Federated Learning Application Runtime Environment

https://nvidia.github.io/NVFlare/

Apache License 2.0

592 stars 165 forks source link

Closed yhwen closed 3 weeks ago

yhwen commented 1 month ago

Fixes # .

A few sentences describing the changes proposed in this pull request.

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[ ] New tests added to cover the changes.
[ ] Quick tests passed locally by running ./runtest.sh.
[ ] In-line docstrings updated.
[ ] Documentation updated.

chesterxgchen commented 1 month ago

oops approve earlier, you need to fix form or unit tests

yhwen commented 1 month ago

oops approve earlier, you need to fix form or unit tests

Fixed

chesterxgchen commented 3 weeks ago

@yhwen @holgerroth this PR has been sitting here for 1 month , is still needed ?

holgerroth commented 3 weeks ago

@yhwen @holgerroth this PR has been sitting here for 1 month , is still needed ?

yes. Still needed.

SYangster commented 3 weeks ago

/build