Enhance ModelController arguments - Githubissues

NVIDIA / NVFlare

NVIDIA Federated Learning Application Runtime Environment

https://nvidia.github.io/NVFlare/

Apache License 2.0

592 stars 165 forks source link

Enhance ModelController arguments #2683

Closed SYangster closed 1 month ago

SYangster commented 1 month ago

ModelController enhancements #2049

BaseFedAvg: change min_clients -> num_clients for clarity now that we hid wait_time_after_min_received and we are sending to num_clients targets rather than all clients.
Improve docstring of sample_clients()
Clarify meaning of timeout in send_model_and_wait() and send_model()
Add min_responses and hide wait_time_after_min_received (https://github.com/NVIDIA/NVFlare/pull/2675)

Types of changes

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[ ] New tests added to cover the changes.
[ ] Quick tests passed locally by running ./runtest.sh.
[ ] In-line docstrings updated.
[ ] Documentation updated.

SYangster commented 1 month ago

/build