[2.4] Minor fix for instructions in setup_poc.ipynb

NVIDIA / NVFlare

NVIDIA Federated Learning Application Runtime Environment

https://nvidia.github.io/NVFlare/

Apache License 2.0

596 stars 170 forks source link

Open hwpang opened 1 month ago

hwpang commented 1 month ago

Minor fix for instructions in setup_poc.ipynb in the examples/tutorials folder.

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[ ] New tests added to cover the changes.
[ ] Quick tests passed locally by running ./runtest.sh.
[ ] In-line docstrings updated.
[ ] Documentation updated.

YuanTingHsieh commented 1 month ago

@hwpang can you prepare one PR to fix this for main branch as well, thanks

hwpang commented 1 month ago

@YuanTingHsieh Yes, will do

chesterxgchen commented 3 weeks ago

/build

YuanTingHsieh commented 2 weeks ago

@hwpang can you open one against the 2.4 branch? thank you!

chesterxgchen commented 4 days ago

@YuanTingHsieh can you help to move this PR to 2.4 branch

hwpang commented 3 days ago

@YuanTingHsieh @chesterxgchen I've opened the PR at https://github.com/NVIDIA/NVFlare/pull/2928!