Ignore TenSeal errors if not secure horizontal training - Githubissues

NVIDIA / NVFlare

NVIDIA Federated Learning Application Runtime Environment

https://nvidia.github.io/NVFlare/

Apache License 2.0

596 stars 170 forks source link

Ignore TenSeal errors if not secure horizontal training #2774

Closed nvidianz closed 1 month ago

nvidianz commented 1 month ago

Fixes FLARE-2152.

Description

Ignore Tenseal errors if not horizontal secure training.
Fixed a bug in PR #2771 where wrong header is used. The code works but not correct.

Types of changes

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[ ] New tests added to cover the changes.
[ ] Quick tests passed locally by running ./runtest.sh.
[ ] In-line docstrings updated.
[ ] Documentation updated.

YuanTingHsieh commented 1 month ago

let's wait for #2773 and resolve conflicts after

nvidianz commented 1 month ago

PR is based on the wrong version of xgboost. Will do another PR.