NVIDIA / NVFlare

NVIDIA Federated Learning Application Runtime Environment
https://nvidia.github.io/NVFlare/
Apache License 2.0
598 stars 171 forks source link

BugFix: Hierarchical Fed Stats, prepare data: replace os.rename() function #2921

Closed chesterxgchen closed 1 week ago

chesterxgchen commented 1 week ago

Fixes # .replace os.rename() to shutil.move() to avoid os.error when destination and src are in different mnt or devices

Types of changes

chesterxgchen commented 1 week ago

os.rename doesn't work across filesystems while shutl.move does. However, why we need to write a csv file then move it. Can we write it directly to dataset_path/university-N/university-N.csv?

Good point, this is someone else code, I did not pay attention and only fixed the QA reported error. Let me change it

chesterxgchen commented 1 week ago

/build

chesterxgchen commented 1 week ago

/build