Improve json serialization to accomodate numpy float32 - Githubissues

NVIDIA / NVFlare

NVIDIA Federated Learning Application Runtime Environment

https://nvidia.github.io/NVFlare/

Apache License 2.0

645 stars 181 forks source link

Improve json serialization to accomodate numpy float32 #3028

Open YuanTingHsieh opened 1 month ago

YuanTingHsieh commented 1 month ago

Since numpy 2.0, some type promoting rules are different: https://numpy.org/devdocs/numpy_2_0_migration_guide.html#changes-to-numpy-data-type-promotion

Description

Change to always cast np.float32 to np.float64 (for serialization) before calling json.dump

Types of changes

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[ ] New tests added to cover the changes.
[ ] Quick tests passed locally by running ./runtest.sh.
[ ] In-line docstrings updated.
[ ] Documentation updated.

YuanTingHsieh commented 1 month ago

/build

YuanTingHsieh commented 3 weeks ago

/build