search

NVIDIA / NVTX

The NVIDIA® Tools Extension SDK (NVTX) is a C-based Application Programming Interface (API) for annotating events, code ranges, and resources in your applications.
Apache License 2.0
312 stars 48 forks source link

Python nvtx.push_range function missing category argument #16

Closed beru closed 3 years ago

beru commented 3 years ago

https://github.com/NVIDIA/NVTX/blob/24a123e8b2c6bd498a27dbe867a96a8c01b0f583/python/nvtx/nvtx.py#L123

this should be

def push_range(message=None, color="blue", domain=None, category=None):

since category is used here.

https://github.com/NVIDIA/NVTX/blob/24a123e8b2c6bd498a27dbe867a96a8c01b0f583/python/nvtx/nvtx.py#L152

beru commented 3 years ago

@shwina Please take a look.

shwina commented 3 years ago

Thanks for reporting! This should be fixed in nvtx 0.2.3 (installable via pip). Will close out this issue once a conda package is available too.

beru commented 3 years ago

Thank you for fixing the problem, team green. It's working well now.