NVIDIA / NVTX

The NVIDIA® Tools Extension SDK (NVTX) is a C-based Application Programming Interface (API) for annotating events, code ranges, and resources in your applications.
Apache License 2.0
312 stars 48 forks source link

Remove unnecessary SFINAE #33

Closed jrhemstad closed 3 years ago

jrhemstad commented 3 years ago

The variadic ctors that forward arguments to the event_attributes constructor were unnecessarily disabled for when the first argument was an event_attributes to avoid a copy. I don't know why I did this originally as it is not necessary.

When a concrete event_attributes object is passed, the overload that expects an event_attributes will be unambiguously selected.

Example https://godbolt.org/z/nTM5Wdoor

jcohen-nvidia commented 3 years ago

Looks good.