NVIDIA / NeMo-Aligner

Scalable toolkit for efficient model alignment
Apache License 2.0
620 stars 78 forks source link

feat: update dockerfile to allow incremental builds and change TRTLLM error to point to dockerfile #290

Closed terrykong closed 1 month ago

terrykong commented 2 months ago

What does this PR do ?

This PR contains two changes:

  1. Change to the dockerfile to allow two types of builds
    
    # Original build
    docker buildx build -t aligner:latest .

An incremental build where only nemo-aligner gets bumped changes

docker buildx build --target=aligner-bump \ --build-arg=BASE_IMAGE=nvcr.io/nvidia/nemo:24.07 \ --build-arg=ALIGNER_COMMIT=dev \ -t aligner:latest .


2. Moves the error message when either (a) TRTLLM isn't installed (b) doesn't have v10 refit functionality into GenerateGPTLLM and have the message point to this new dockerfile

# Changelog 
- Please update the [CHANGELOG.md](/CHANGELOG.md) under next version with high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

Additional Information

terrykong commented 1 month ago

Push this into dev instead