NVIDIA / NeMo-Aligner

Scalable toolkit for efficient model alignment
Apache License 2.0
628 stars 78 forks source link

Fixed string literal error #338

Closed SulRash closed 3 days ago

SulRash commented 1 month ago

What does this PR do ?

Fixed the following string literal bug:

Traceback (most recent call last):
  File "/eph/nvme0/azureml/cr/j/5f8208feac9e43b3b90284ba713c821b/exe/wd/train_reward_model.py", line 22, in <module>
    from nemo_aligner.data.nlp.builders import (
  File "/opt/NeMo-Aligner/nemo_aligner/data/nlp/builders.py", line 45, in <module>
    from nemo_aligner.data.nlp.datasets import (
  File "/opt/NeMo-Aligner/nemo_aligner/data/nlp/datasets.py", line 346
    WARNING: It's recommended to preprocess your data in advance to ensure all samples are within self.seq_length.
               ^
SyntaxError: unterminated string literal (detected at line 346)

By changing It's to It is. This fix offers a wider range of compatibility without really modifying any of the logic.

Changelog

Changelog updated

Before your PR is "Ready for review"

Pre checks:

SulRash commented 1 month ago

@gshennvm @odelalleau