Closed VibhuJawa closed 4 months ago
CC: @sarahyurick for an initial review.
Side note: NeMo-Curator requires all PR's to include both signed commits as well as signed-off. This can be enabled with git commit -sS ...
.
There's some more info in https://github.com/NVIDIA/NeMo-Curator/blob/main/CONTRIBUTING.md#pull-requests-pr-guidelines.
Side note: NeMo-Curator requires all PR's to include both signed commits as well as signed-off. This can be enabled with
git commit -sS ...
. There's some more info in https://github.com/NVIDIA/NeMo-Curator/blob/main/CONTRIBUTING.md#pull-requests-pr-guidelines.
Thanks, fixed it.
@sarahyurick , I have added the quality model and cleaned up scripts, Can i get a re-review please.
Really sorry for the commit noise guys (@ryantwolf , @sarahyurick ), i messed up one of the git rebase (forgot to sign off a commit).
This should be ready for another review now. Have addressed all the reviews and added issues to follow up ones that i could not get to in this PR.
@ryantwolf , Thanks again for all the careful reviews. Appreciate the help . I think i should have those resolved.
This PR enables using Crossfit.
Todo:
Benchmarks:
A100 numbers: