NVIDIA / NeMo-text-processing

NeMo text processing for ASR and TTS
https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/nlp/text_normalization/wfst/wfst_text_normalization.html
Apache License 2.0
242 stars 77 forks source link

Jp itn #101

Closed BuyuanCui closed 1 month ago

BuyuanCui commented 10 months ago

What does this PR do ?

Merge to main for Japanese support on cardinal, ordinal, time, date, fraction, decimal support Add a one line overview of what this PR aims to accomplish. This is a PR for Japanese ITN support.

Before your PR is "Ready for review"

Pre checks:

PR Type:

If you haven't finished some of the above items you can still open "Draft" PR.

github-actions[bot] commented 8 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

lazykyama commented 8 months ago

@BuyuanCui I reviewed the latest codes and it's almost OK. But, I'm so sorry that it looks like I missed one more thing.

So far, the package and directory names include jp like nemo_text_processing/inverse_text_normalization/jp/__init__.py, but I think it would be better to be the same with a standard language code (https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes). Would it be necessary to follow this standard? If yes, it should be changed to ja. If not, please ignore this.

So sorry again for this late comment. There's no additional thing except for this. Thanks.

github-actions[bot] commented 7 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] commented 7 months ago

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] commented 6 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] commented 5 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] commented 5 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] commented 4 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] commented 3 months ago

This PR was closed because it has been inactive for 7 days since being marked as stale.

ekmb commented 2 months ago

@BuyuanCui should we close this PR in favor of https://github.com/NVIDIA/NeMo-text-processing/pull/141 ?

github-actions[bot] commented 1 month ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] commented 1 month ago

This PR was closed because it has been inactive for 7 days since being marked as stale.