Closed BuyuanCui closed 1 month ago
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
@BuyuanCui I reviewed the latest codes and it's almost OK. But, I'm so sorry that it looks like I missed one more thing.
So far, the package and directory names include jp
like nemo_text_processing/inverse_text_normalization/jp/__init__.py
, but I think it would be better to be the same with a standard language code (https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes). Would it be necessary to follow this standard? If yes, it should be changed to ja
. If not, please ignore this.
So sorry again for this late comment. There's no additional thing except for this. Thanks.
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
This PR was closed because it has been inactive for 7 days since being marked as stale.
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
This PR was closed because it has been inactive for 7 days since being marked as stale.
@BuyuanCui should we close this PR in favor of https://github.com/NVIDIA/NeMo-text-processing/pull/141 ?
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
This PR was closed because it has been inactive for 7 days since being marked as stale.
What does this PR do ?
Merge to main for Japanese support on cardinal, ordinal, time, date, fraction, decimal support Add a one line overview of what this PR aims to accomplish. This is a PR for Japanese ITN support.
Before your PR is "Ready for review"
Pre checks:
git commit -s
to sign.pytest
or (if your machine does not have GPU)pytest --cpu
from the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')
). 2) Sparrowhawk testsbash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
pytest
and Sparrowhawk here.__init__.py
for every folder and subfolder, includingdata
folder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
to all newly added Python files?Copyright 2015 and onwards Google, Inc.
. See an example here.try import: ... except: ...
) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.