GiacomoLeoneMaria commented 1 year ago

What does this PR do ?

Adds TIME class to text normalization for Italian.

Before your PR is "Ready for review"

Pre checks:

[x] Have you signed your commits? Use git commit -s to sign.
[x] 1) pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
- [ ] 2) Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
[x] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
[x] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
[x] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
[x] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.

PR Type:

github-actions[bot] commented 11 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

mgrafu commented 11 months ago

@GiacomoLeoneMaria can you address the CodeQL comments so this PR can move forward?

mgrafu commented 11 months ago

@GiacomoLeoneMaria can you also add a test case (it can be in either time or maybe better cardinals) that includes normalization for the number 38?