search

NVIDIA / NeMo-text-processing

NeMo text processing for ASR and TTS
https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/nlp/text_normalization/wfst/wfst_text_normalization.html
Apache License 2.0
242 stars 77 forks source link

logs added directly to the root logger making it harder to mute or control #119

Closed riqiang-dp closed 8 months ago

riqiang-dp commented 8 months ago

I believe this line here adds the logs directly to the root logger. Shouldn't it be logger.info instead of logging.info?

I'm using nemo-text-processing within another process and want to change the log level just with nemo-text-processing

https://github.com/NVIDIA/NeMo-text-processing/blob/0ded21aad55c68189d1695c64c2b8e9fef71ef00/nemo_text_processing/text_normalization/data_loader_utils.py#L347

ekmb commented 8 months ago

Thanks for reporting! Fixed in https://github.com/NVIDIA/NeMo-text-processing/pull/118