anand-nv
commented
10 months ago This test doesn't work correctly for me with the original weights. Not sure how it passed the tests.
From: Evelina @.> Sent: Wednesday, November 22, 2023 2:01:50 AM To: NVIDIA/NeMo-text-processing @.> Cc: Anand Joseph @.>; Author @.> Subject: Re: [NVIDIA/NeMo-text-processing] Increase weights for serial (en TN) (PR #128)
@ekmb requested changes on this pull request.
In tests/nemo_text_processing/en/data_text_normalization/test_cases_money.txthttps://github.com/NVIDIA/NeMo-text-processing/pull/128#discussion_r1401135535:
@@ -63,3 +63,4 @@ $1,925.21~one thousand nine hundred and twenty five dollars twenty one cents $1,234.123~one thousand two hundred and thirty four point one two three dollars US $76.3 trillion~US seventy six point three trillion dollars US$76.3 trillion~seventy six point three trillion us dollars +The price for each canned salmon is $5, each bottle of peanut butter is $3~The price for each canned salmon is five dollars, each bottle of peanut butter is three dollars
seems like the added test case was working w/o weight update. Could you please replace with the input from this issuehttps://github.com/NVIDIA/NeMo-text-processing/issues/126Thank you for the quantities. Now, lets talk about the pricing. The price for each canned salmon is \$5, each bottle of peanut butter is \$3
— Reply to this email directly, view it on GitHubhttps://github.com/NVIDIA/NeMo-text-processing/pull/128#pullrequestreview-1743023126, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZICZSILKH6BOTWR65Y5SMLYFUFTNAVCNFSM6AAAAAA7QGHHRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBTGAZDGMJSGY. You are receiving this because you authored the thread.Message ID: @.***>
What does this PR do ?
Increase weights for serial (en TN)
PR Type: