Closed ChinmayPatil11 closed 6 months ago
The following commits do not have signoff
- Commit sha: [29f0e06](https://github.com/NVIDIA/NeMo-text-processing/pull/129/commits/29f0e0680b8f20bf4f6bc2695228fff7c46379af), Author: Chinmay Patil, Committer: Chinmay Patil; The sign-off is missing.
- Commit sha: [200f941](https://github.com/NVIDIA/NeMo-text-processing/pull/129/commits/200f941a7124d25cd51434dbf15c6cc7f72870a1), Author: Chinmay Patil, Committer: Chinmay Patil; The sign-off is missing.
- Commit sha: [a2846c0](https://github.com/NVIDIA/NeMo-text-processing/pull/129/commits/a2846c0fe76ce232dde650b6358195299638539b), Author: Chinmay Patil, Committer: Chinmay Patil; The sign-off is missing.
- Commit sha: [c042973](https://github.com/NVIDIA/NeMo-text-processing/pull/129/commits/c0429732196ca211c1b636b56709d2d1f2922b3b), Author: Chinmay Patil, Committer: Chinmay Patil; The sign-off is missing.
- Commit sha: [eb82d32](https://github.com/NVIDIA/NeMo-text-processing/pull/129/commits/eb82d323c00890ab0bec3968f1068da1917519a2), Author: Chinmay Patil, Committer: Chinmay Patil; The sign-off is missing.
Hi @anand-nv I'm having a bit of a difficulty with clearing the issues in this given pull request as this is my first contribution to an open sourced project. Is it possible for this pr to be closed and I create a new pr for the same feature? I think It might be easier for me to do so. Thanks.
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
What does this PR do ?
This is a PR for marathi ITN support for Cardinal, Decimal, Date and Time categories.
Before your PR is "Ready for review"
Pre checks:
git commit -s
to sign.pytest
or (if your machine does not have GPU)pytest --cpu
from the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')
). 2) Sparrowhawk testsbash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
pytest
and Sparrowhawk here.__init__.py
for every folder and subfolder, includingdata
folder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
to all newly added Python files?Copyright 2015 and onwards Google, Inc.
. See an example here.try import: ... except: ...
) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.