ChinmayPatil11 commented 6 months ago

What does this PR do ?

This is a PR for marathi ITN support for Cardinal, Decimal, Date and Time categories.

Before your PR is "Ready for review"

Pre checks:

[x] Have you signed your commits? Use git commit -s to sign.
[x] Do all unittests finish successfully before sending PR? 1) pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')). 2) Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
[x] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
[x] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
[x] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
[x] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
[x] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
[x] Remove import guards (try import: ... except: ...) if not already done.
[x] If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
[x] Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

[x] New Feature
[x] Documentation

@ekmb

github-actions[bot] commented 5 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

ChinmayPatil11 commented 5 months ago

Hi @ekmb Can you please check and approve on the PR? I have added a PR on the NeMo repo as well with added feature. Thanks.

ekmb commented 5 months ago

@ChinmayPatil11 thank you for the PR!

Could you please address CodeQL errors.

ChinmayPatil11 commented 5 months ago

@ChinmayPatil11 thank you for the PR!

Could you please address CodeQL errors.

Sure I will, thanks for the review. Meanwhile can you please remove the stale tag on the corresponding PR to NeMo repository? https://github.com/NVIDIA/NeMo/pull/8117 Thanks!

github-actions[bot] commented 4 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

ChinmayPatil11 commented 4 months ago

Hi @ekmb, can you please check on the review. I have done the required changes on my part. Thanks!

ekmb commented 4 months ago

Hi @ekmb, can you please check on the review. I have done the required changes on my part. Thanks!

Hi @ChinmayPatil11 , could you please add pytests + sparrowhawk tests to the jenkins file? Examples: https://github.com/NVIDIA/NeMo-text-processing/pull/134/files# [create cache files] https://github.com/NVIDIA/NeMo-text-processing/blob/main/Jenkinsfile#L333 [run all pytests] https://github.com/NVIDIA/NeMo-text-processing/blob/main/Jenkinsfile#L393 [run SH tests]

Thanks!

github-actions[bot] commented 4 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

tbartley94 commented 3 months ago

jenkins

tbartley94 commented 3 months ago

jenkins

tbartley94 commented 3 months ago

jenkins

tbartley94 commented 3 months ago

jenkins

NVIDIA / NeMo-text-processing

Marathi ITN #134

What does this PR do ?

Before your PR is "Ready for review"