Armenian TN

[davidks13]

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

• [x] Have you signed your commits? Use git commit -s to sign.
• [x] Do all unittests finish successfully before sending PR? 1) pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')). 2) Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
• [x] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
• [x] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
• [ ] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
• [x] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
• [ ] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
• [x] Remove import guards (try import: ... except: ...) if not already done.
• [ ] If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
• [x] Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

• [x] New Feature
• [ ] Bugfix
• [ ] Documentation
• [x] Test

If you haven't finished some of the above items you can still open "Draft" PR.

[davidks13]

Hi @ekmb . What should I do to pass this check ''continuous-integration/jenkins/pr-head''? I could not open details of that check. Thank you!

[tbartley94]

Hi @ekmb . What should I do to pass this check ''continuous-integration/jenkins/pr-head''? I could not open details of that check. Thank you!

That's CI on our end. Can't really access if you're not a maintainer. We have to check and provide feedback. Sorry, can be a bit annoying.

[tbartley94]

@Ara-Yeroyan are there additional issues with this or can I close out reviewing?

[Ara-Yeroyan]

Everything is okay now! The pynini behaviour was different on Windows (docker) and in linux. We have checked with @davidks13.

[davidks13]

Hi @tbartley94 . Are there any additional issues with the code I need to check?

[Ara-Yeroyan]

Actually there are issues (no handling) with Roman Numbers and the range like numbers - e.g. 26-27

[davidks13]

Actually there are issues (no handling) with

This is a base for Armenian TN. Those features can be added in the future.

[tbartley94]

@davidks13 you're good on my technical review. There's a CI issue that requires me to test on local, so the delay is me doing some san testing. I'll be merging later in the week.

@Ara-Yeroyan Roman and ranges are more complex features that are implemented after base TN. Those can be disregarded.

[tbartley94]

jenkins