NVIDIA / NeMo-text-processing

NeMo text processing for ASR and TTS
https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/nlp/text_normalization/wfst/wfst_text_normalization.html
Apache License 2.0
242 stars 76 forks source link

Poetry support #145

Closed jvdw-synth closed 2 months ago

jvdw-synth commented 4 months ago

Is your feature request related to a problem? Please describe.

Poetry cannot install nemo-text-processing. See following script:

#!/bin/bash

set -ex

# Demo the failure of installing pynini==2.1.5 and that this also blocks installing nemo text processing

# Install poetry if not already installed
if ! command -v poetry &> /dev/null
then
    echo "poetry not found, installing poetry"
    curl -sSL https://install.python-poetry.org | python3 - -y
fi

# Add poetry to path
PATH="$PATH:$HOME/.local/bin"

# Make project and install pynini==2.1.5
# Set clean up on exit using trap
trap "rm -rf /tmp/pynini-test" EXIT

cd /tmp
rm -rf pynini-test
mkdir pynini-test
cd pynini-test
poetry init -n

# Install nemo text processing will show an error
poetry add nemo_text_processing==0.2.2rc0

Describe the solution you'd like

No error on poetry add.

Describe alternatives you've considered

Alternatives are pip install, but poetry happens to be a widely adopted package manager, so support for this would be great.

Additional context

I've opened a PR to support poetry here https://github.com/NVIDIA/NeMo-text-processing/pull/144

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 2 months ago

This issue was closed because it has been inactive for 7 days since being marked as stale.