Open kurt0cougar opened 1 month ago
@kurt0cougar Implementation question: what's the rational for keeping the cardinals as a separate file. Does reading from file improve graph construction speed that much?
@elenaltz Do we have a format for shared copyright headers?
@elenaltz Do we have a format for shared copyright headers?
@tbartley94 do you mean something like this https://github.com/NVIDIA/NeMo-text-processing/blob/main/nemo_text_processing/hybrid/mlm_scorer.py
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
@kurt0cougar Any questions on comments?
…ransliteration semiotic classes
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Before your PR is "Ready for review"
Pre checks:
git commit -s
to sign.pytest
or (if your machine does not have GPU)pytest --cpu
from the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')
). 2) Sparrowhawk testsbash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
pytest
and Sparrowhawk here.__init__.py
for every folder and subfolder, includingdata
folder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
to all newly added Python files?Copyright 2015 and onwards Google, Inc.
. See an example here.try import: ... except: ...
) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.