NVIDIA / NeMo-text-processing

NeMo text processing for ASR and TTS
https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/nlp/text_normalization/wfst/wfst_text_normalization.html
Apache License 2.0
258 stars 84 forks source link

add latest ES TN/ITN and tests #19

Closed mgrafu closed 1 year ago

mgrafu commented 1 year ago

Signed-off-by: Mariana Graterol Fuenmayor mgrafu@gmail.com

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Usage

# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

PR Type:

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

mgrafu commented 1 year ago

Thanks for the feedback, @yzhang123 !

  1. Copyright files updated
  2. Checked that all subfolders have an init.py file
  3. Removed unused imports per codeQL
yzhang123 commented 1 year ago

Thanks for the feedback, @yzhang123 !

  1. Copyright files updated
  2. Checked that all subfolders have an init.py file
  3. Removed unused imports per codeQL

thanks @mgrafu . But am I missing something, the folder inverse_text_normalization/es/data/electronic does not have init file

mgrafu commented 1 year ago

Thanks for the feedback, @yzhang123 !

  1. Copyright files updated
  2. Checked that all subfolders have an init.py file
  3. Removed unused imports per codeQL

thanks @mgrafu . But am I missing something, the folder inverse_text_normalization/es/data/electronic does not have init file

@yzhang123 the init.py file for this directory exists in main (it was an already existing directory before this pr) so it's not reflected in these changes :)