NVIDIA / NeMo-text-processing

NeMo text processing for ASR and TTS
https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/nlp/text_normalization/wfst/wfst_text_normalization.html
Apache License 2.0
246 stars 80 forks source link

Swedish telephone fix #60

Closed jimregan closed 1 year ago

jimregan commented 1 year ago

What does this PR do ?

59 added a fix for the Swedish sparrowhawk script, this adds fixes to make sure the telephone tests pass

Before your PR is "Ready for review"

Pre checks:

PR Type:

If you haven't finished some of the above items you can still open "Draft" PR.

ekmb commented 1 year ago

@jimregan it says it's a bug fix, if so, do you want to add any additional test cases that failed previously but covered now?

jimregan commented 1 year ago

@jimregan it says it's a bug fix, if so, do you want to add any additional test cases that failed previously but covered now?

The test files were fine, they just weren't being called from the sparrowhawk script.

jimregan commented 1 year ago

@jimregan it says it's a bug fix, if so, do you want to add any additional test cases that failed previously but covered now?

The test files were fine, they just weren't being called from the sparrowhawk script.

@ekmb rather, the telephone tests weren't being called, that was fixed in the 'es bugfix' commit, this changes the telephone tagger to match the schema used by sparrowhawk.

github-actions[bot] commented 1 year ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.