Closed jimregan closed 1 year ago
@jimregan it says it's a bug fix, if so, do you want to add any additional test cases that failed previously but covered now?
@jimregan it says it's a bug fix, if so, do you want to add any additional test cases that failed previously but covered now?
The test files were fine, they just weren't being called from the sparrowhawk script.
@jimregan it says it's a bug fix, if so, do you want to add any additional test cases that failed previously but covered now?
The test files were fine, they just weren't being called from the sparrowhawk script.
@ekmb rather, the telephone tests weren't being called, that was fixed in the 'es bugfix' commit, this changes the telephone tagger to match the schema used by sparrowhawk.
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
What does this PR do ?
59 added a fix for the Swedish sparrowhawk script, this adds fixes to make sure the telephone tests pass
Before your PR is "Ready for review"
Pre checks:
git commit -s
to sign.pytest
or (if your machine does not have GPU)pytest --cpu
from the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')
). 2) Sparrowhawk testsbash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
pytest
and Sparrowhawk here.__init__.py
for every folder and subfolder, includingdata
folder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
to all newly added Python files?Copyright 2015 and onwards Google, Inc.
. See an example here.try import: ... except: ...
) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.