Add a one line overview of what this PR aims to accomplish.
Changes include changing the class char to word. This means the python files in tagger, verbalizer and tests are changed.
[ *] Have you signed your commits? Use git commit -s to sign.
[ *] Do all unittests finish successfully before sending PR?
1) pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
2) Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
[ ] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
[ *] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
[ *] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
[ *] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
What does this PR do ?
Add a one line overview of what this PR aims to accomplish. Changes include changing the class char to word. This means the python files in tagger, verbalizer and tests are changed.
tagger/char.py -> word.py verbalizer/char.py -> word.py tests/zh/test_cases_char.txt -> test_cases_word.txt tests/zh/test_char.py -> test_word.py
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')). 2) Sparrowhawk testsbash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.