fix exp_manager.py to work on Windows

NVIDIA / NeMo

A scalable generative AI framework built for researchers and developers working on Large Language Models, Multimodal, and Speech AI (Automatic Speech Recognition and Text-to-Speech)

https://docs.nvidia.com/nemo-framework/user-guide/latest/overview.html

Apache License 2.0

12.13k stars 2.52k forks source link

fix exp_manager.py to work on Windows #10275

Closed BBC-Esq closed 1 month ago

BBC-Esq commented 2 months ago

In the exp_manager.py script, you need to change the line that reads

rank_termination_signal: signal.Signals = signal.SIGKILL

to...

rank_termination_signal: signal.Signals = signal.SIGTERM if os.name == 'nt' else signal.SIGKILL

That way it will work on Windows.

You're welcome.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 month ago

This issue was closed because it has been inactive for 7 days since being marked as stale.