A scalable generative AI framework built for researchers and developers working on Large Language Models, Multimodal, and Speech AI (Automatic Speech Recognition and Text-to-Speech)
CosineAnnealing LR with linear warmup and constant_steps is 0 on the first step. This causes issues for AdamW optimizer which uses LR for step_size in the denominator. This is due to the fact on first step when this method is called step=0 before the first optimizer step is complete.
Collection: [Note which collection this PR will affect]
Core
Changelog
fix cosine annealing linear warmup LR
Usage
You can potentially add a usage example below
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
[x] Did you add or update any necessary documentation?
[ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
[ ] Reviewer: Does the PR have correct import guards for all optional libraries?
PR Type:
[ ] New Feature
[x] Bugfix
[ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
What does this PR do ?
CosineAnnealingLR with linear warmup andconstant_stepsis0on the first step. This causes issues for AdamW optimizer which uses LR forstep_sizein the denominator. This is due to the fact on first step when this method is calledstep=0before the first optimizer step is complete.Using the same protection as in:
Updated unit tests not to tolerate LR=0.
Collection: [Note which collection this PR will affect]
Core
Changelog
Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information