NVIDIA / NeMo

A scalable generative AI framework built for researchers and developers working on Large Language Models, Multimodal, and Speech AI (Automatic Speech Recognition and Text-to-Speech)
https://docs.nvidia.com/nemo-framework/user-guide/latest/overview.html
Apache License 2.0
12.14k stars 2.53k forks source link

Upgrade librosa version to fix librosa.display.specshow issue in ASR tutorial notebooks #10553

Closed github-actions[bot] closed 1 month ago

github-actions[bot] commented 1 month ago

What does this PR do ?

Matplotlib removed matplotlib.cm.get_cmap 3.9.0 onwards (deprecated since 3.7.0). This causes an error in our ASR tutorials (ASR_for_telephony_speech.ipynb, Speech_Enhancement_with_NeMo.ipynb, Online_Offline_Microphone_VAD_Demo.ipynb) that use librosa.display.specshow, which internally calls matplotlib.cm.get_cmap(name). Librosa fixed it with this PR: https://github.com/librosa/librosa/pull/1782. Hence, lower bounding librosa to 0.10.2 in our requirements.txt to account for the above change.

Collection: [Note which collection this PR will affect] ASR

Changelog

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

PR Type:

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information