Closed maanug-nv closed 1 month ago
One consideration is whether to call the base class's impl at the start or end of our impl. If we do it at the start, we are timing these file operations as part of the first train time interval. So, I think it makes more sense to do it at the end.
One consideration is whether to call the base class's impl at the start or end of our impl. If we do it at the start, we are timing these file operations as part of the first train time interval. So, I think it makes more sense to do it at the end.
Thanks Maanu! I agree that it makes more sense to add the call at the end.
What does this PR do ?
Missing baseclass call. Fixes checkpointing with
train_time_interval
Collection: [Note which collection this PR will affect]
Changelog
Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information