NVIDIA / NeMo

A scalable generative AI framework built for researchers and developers working on Large Language Models, Multimodal, and Speech AI (Automatic Speech Recognition and Text-to-Speech)
https://docs.nvidia.com/nemo-framework/user-guide/latest/overview.html
Apache License 2.0
11.66k stars 2.44k forks source link

set maxlen based on stage and obey max_seq_length settings #9477

Closed arendu closed 2 months ago

arendu commented 3 months ago

What does this PR do ?

memory/tokens for generation is pre-assigned with size min(context_lenght + tokens_to_generate, max_seq_length)

This causes a crash if context_length + tokens_to_generate > max_seq_length because the clipping strategy was not doing any clipping of the maxlen.

This PR adds the clipping strategy for models that don't use learned position embeddings.

Collection: [NLP]

Changelog

Usage

# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

PR Type:

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

github-actions[bot] commented 3 months ago

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] commented 2 months ago

This PR was closed because it has been inactive for 7 days since being marked as stale.