NVIDIA / NeMo

A scalable generative AI framework built for researchers and developers working on Large Language Models, Multimodal, and Speech AI (Automatic Speech Recognition and Text-to-Speech)
https://docs.nvidia.com/nemo-framework/user-guide/latest/overview.html
Apache License 2.0
11.63k stars 2.44k forks source link

Update TransformerEngine initialize_ub parameters #9536

Closed thomasdhc closed 2 months ago

thomasdhc commented 3 months ago

What does this PR do ?

Update TransformerEngine and update paramters of initialize_ub function

Collection: [nlp]

Changelog

Usage

# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

PR Type:

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

thomasdhc commented 3 months ago

TE PR that updated the parameters: https://github.com/NVIDIA/TransformerEngine/pull/901

pablo-garay commented 3 months ago

CI passed (test that failed flaky & is now fixed): https://github.com/NVIDIA/NeMo/actions/runs/9702489435

thomasdhc commented 2 months ago

This change is no longer needed with new TE changes: https://github.com/NVIDIA/TransformerEngine/pull/986