NVIDIA / NeMo

A scalable generative AI framework built for researchers and developers working on Large Language Models, Multimodal, and Speech AI (Automatic Speech Recognition and Text-to-Speech)
https://docs.nvidia.com/nemo-framework/user-guide/latest/overview.html
Apache License 2.0
10.79k stars 2.26k forks source link

Fix lhotse tests for v1.24.2 #9546

Closed pzelasko closed 2 days ago

pzelasko commented 2 days ago

What does this PR do ?

These tests were failing on main when torchaudio was present in the container. The changes are caused by the dynamic bucketing sampler optimization in the new lhotse version - the sampler simply draws different buckets in the test setup. I removed the conditional trigger on torchaudio since newer lhotse versions don't require it for the functionalities under test anymore.

Edit: also fixing a new regression in RIR test (the random seed was not fixed).

Collection: [Note which collection this PR will affect]

Changelog

Usage

# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

PR Type:

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information