NVIDIA / Q2RTX

NVIDIA’s implementation of RTX ray-tracing in Quake II
Other
1.21k stars 180 forks source link

[regresssion] Graphic does not render correctly #312

Closed runlevel5 closed 10 months ago

runlevel5 commented 10 months ago

I can confirm https://github.com/NVIDIA/Q2RTX/pull/308 has caused regression to the game renderer

Before

Screenshot from 2023-08-26 01-20-31

After

Screenshot from 2023-08-26 01-39-08

System Info

Hardware Information:

Software Information:

cc @res2k wondering if you get the same issue on your Linux box

res2k commented 10 months ago

Can't reproduce. On Windows right now, but can try Linux later. However, as the shaders have changed, please confirm you're using up-to-date compiled shaders (.spv files), and not, say, those from the last release.

res2k commented 10 months ago

Can't reproduce on Linux either. Not that that's saying much, considering pretty much everything else is different.

apanteleev commented 10 months ago

Latest master works fine for me also. Make sure that your shaders are rebuilt.

runlevel5 commented 10 months ago

Please excuse my ignorance, how could I package the shaders?

AFAIK there is https://github.com/NVIDIA/Q2RTX/blob/b3cd8597aabd94cb95ddac5a9b70c4e658aaa306/setup/package_shaders.bat#L5

which basically compress the baseq2/shader_vkpt to produce shaders.pkz.

res2k commented 10 months ago

Well, as that script suggests, you could use any tool that can generate ZIP archives to do the packaging (.pkz files are just zip archives with a different extension.) However, that is not actually necessary: you just need to make sure the "shader_vkpt" directory, generated by the Q2RTX build, is in the right place - which would be the game data directory, baseq2 (there e.g. blue_noise.pkz should be located as well).

runlevel5 commented 10 months ago

Great thanks for helping me. I am closing this issue now.