search

NVIDIA / Q2RTX

NVIDIA’s implementation of RTX ray-tracing in Quake II
Other
1.22k stars 181 forks source link

Scale the view weapon to prevent intersection with walls #319

Closed apanteleev closed 1 year ago

apanteleev commented 1 year ago

Following up on https://github.com/NVIDIA/Q2RTX/issues/318

res2k commented 1 year ago

Shouldn't the v_flareg case be adjusted to gun.scale *= 0.3f; (*= instead of =)?

Generally seems to work well. I agree to the lighting differences not really being noticeable "unless you look for it".

If you set more extreme scale values (eg 0.01), the gun isn't just "slightly shifting on screen", it's doing quite the funny stuff. Might be interesting to see why that is... but the current default generally looks fine, so IMO some explanation would just be "nice to have".

res2k commented 1 year ago

@WatIsDeze, if you could also look how this behaves in the corner case(s) you found, that would be grand!

apanteleev commented 1 year ago

Changes were made, thanks for the feedback @res2k