search

NVIDIA / Q2RTX

NVIDIA’s implementation of RTX ray-tracing in Quake II
Other
1.22k stars 181 forks source link

Bump SDL2 to 2.30.1 #394

Closed runlevel5 closed 5 months ago

runlevel5 commented 6 months ago

To bump this lib to latest v2

apanteleev commented 5 months ago

It's odd but I'm getting many errors building with the new version of SDL2 with Visual Studio Code (VS2022 tools and Ninja). With regular VS2022, it compiles OK.

pr-394-log.txt

runlevel5 commented 5 months ago

@apanteleev is there a pipeline that I could use to reproduce the error?

apanteleev commented 5 months ago

No, I don't have a CI pipeline like that. Just install VS Code and CMake Tools extension, configure and build.

runlevel5 commented 5 months ago

@apanteleev were you using clang or GCC?

apanteleev commented 5 months ago

MSVC from Visual Studio 2022

res2k commented 5 months ago

@apanteleev Did you clean your build directory? In the past, that fixed some weird SDL compilation issues for me after updating it. (I think something, config header or so, isn't correctly updated/regenerated if you keep build files from previous versions.)

apanteleev commented 5 months ago

@res2k Good suggestion! I did a clean build but didn't delete the build directory. Deleting the entire build directory fixes the errors. Merging in a minute...