search

NVIDIA / Q2RTX

NVIDIA’s implementation of RTX ray-tracing in Quake II
Other
1.22k stars 184 forks source link

Bump openal-soft to 1.23.1 #395

Closed runlevel5 closed 6 months ago

runlevel5 commented 8 months ago

TODO

apanteleev commented 7 months ago

Getting many new warnings with the new version: overriding '/W3' with '/W4' for every OAL file, also implicit type conversions from size_t to int and double to float. I'd avoid updating to this version unless it brings noticeable fixes or improvements.

runlevel5 commented 7 months ago

Getting many new warnings with the new version: overriding '/W3' with '/W4' for every OAL file, also implicit type conversions from size_t to int and double to float. I'd avoid updating to this version unless it brings noticeable fixes or improvements.

Fair call. I would prefer to keep it up to date to make things easier for downstream packager. How about I address all of the warnings first then we could revisit this PR?

apanteleev commented 7 months ago

How about I address all of the warnings first then we could revisit this PR?

Sounds good.