Fix lora split #297 - Githubissues

NVIDIA / Stable-Diffusion-WebUI-TensorRT

TensorRT Extension for Stable Diffusion Web UI

MIT License

1.84k stars 139 forks source link

Fix lora split #297 #299

Open Yomisana opened 3 months ago

Yomisana commented 3 months ago

Fix #297 using find the rightmost left bracket "("
Fix #297 multi dot filename can't find issue.(if keep load multi dot and that file it self export have error is not on this issue)
Fix load json of 'cp950'...etc codec can't decode issue
Prevent file names from having multiple spaces that may be encountered(at file name end)

FurkanGozukara commented 1 month ago

is this still necessary? or latest update fixed this?

Yomisana commented 1 month ago

Hi Dr. @FurkanGozukara

is this still necessary?

it depends will your filename have brackets or dot ...etc to effect code of split sd_version and filename extension.
or latest update fixed this?

I guess not. because I track for a while but not have fixed so I guess won't be fix... because this not really important of devs those just let lora folder file can manger filename have some () and . for filename. And right now this repo lastest only check lora root folder file. If lora root folder have subfolder won't read and export all file need at not in root path.

FurkanGozukara commented 1 month ago

Hi Dr. @FurkanGozukara

is this still necessary?

it depends will your filename have brackets or dot ...etc to effect code of split sd_version and filename extension.

or latest update fixed this?

I guess not. because I track for a while but not have fixed so I guess won't be fix... because this not really important of devs those just let lora folder file can manger filename have some () and . for filename. And right now this repo lastest only check lora root folder file. If lora root folder have subfolder won't read and export all file need at not in root path.

Is your repo up to date with latest? I will install it ty

Yomisana commented 1 month ago

Hi Dr. @FurkanGozukara

is this still necessary?

it depends will your filename have brackets or dot ...etc to effect code of split sd_version and filename extension.

or latest update fixed this?

I guess not. because I track for a while but not have fixed so I guess won't be fix... because this not really important of devs those just let lora folder file can manger filename have some () and . for filename. And right now this repo lastest only check lora root folder file. If lora root folder have subfolder won't read and export all file need at not in root path.

Is your repo up to date with latest? I will install it ty

yup it lastest, and I only test A1111 SDW on windows of 2080ti, if any issue you can tell me :D

Yomisana commented 1 month ago

@FurkanGozukara I forgot to tell you the latest repo is Yomisana/Stable-Diffusion-WebUI-TensorRT-Enhanced are latest, fork repo is not latest.

FurkanGozukara commented 1 month ago

@FurkanGozukara I forgot to tell you the latest repo is Yomisana/Stable-Diffusion-WebUI-TensorRT-Enhanced are latest, fork repo is not latest.

awesome i will update my installers with this repo

starred, forked and watching